[ag-automation] [PATCH]master_script_bugfix.diff

[Jan Altenberg]

Hi,

On Fri, Sep 15, 2006 at 12:22:42PM +0200, Luotao Fu wrote:
> Hi,
> I have reviewed, as required, the script for remastering knoppix to 
> OSADL Demo CD, done some fixes fo several minor bugs and made some 
> improvements. Along with this mail I attached the patch with the fixes.

Thanks for your patch! I'll apply your changes, when I'm back to the
office on monday.

> signed-off-by: Luotao Fu (lfu AT pengutronix.de)

acked-by: Jan Altenberg (tb10alj AT tglx.de)

> 1. kernel-configs given in tar-ball, however the script checks keren_config. 
>   bug or feature(R) ?

That's definetely a bug ;-)

> 2. if targetdir is given, script tries to chroot to it subdir source/knoppix.
>   Suppose the user might have created an empty dir to hold the image before 
>   running the script, in this case the script will quit 'cause the chroot will
>   not success. Thus the check here is somehow not quite reasonable, one should 
>   check the content of the target dir to decide if one want to copy.
> 
> 3. After failed run, i.E. running script not as root. script will left created
>   target dir undeleted, makes rerunning impossible.(see point 2)

This part of the script was just a relict, which came in for some
testing purpose. Thanks for the fix!

> 4. -o ro parameter shall also be added to mount command while mounting cloop
>   device to avoid waring

ACKED

> 5. "Debian way" compiling kernel cause unneccessary dialogs and warnings, 
>   makes autobuilding difficult 

Yes, make-kpkg causes some unnecessary noise. We decided to use
make-kpkg to keep the paket management consistent. 
But I would have no doubts about changing the kernel building part of the
script, if the users want me to do.

Carsten, what do you think?

> 6. Requirement unclear: 
> 	* one needs root privileg

Hmmm, I don't think we can do it without root privileges.

> 	* one needs patched kernelsource

Patching the kernel should (and will) be automated.

> 	* one needs cloop 

Klaus Knopper autoloads cloop and UnionFS during the hardware detection.
So we need to provide matching cloop and UnionFS modules for our custom kernel.

> 	* should make clear that cloop needs file= parameter in case loading
> 	manually
> 
> 7. cloop cause oops with 2.6.17+gcc4.1

Ouch, I'll try to reproduce that.

Regards
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.osadl.org/pipermail/ag-automation/attachments/20060915/9ce9829c/attachment.pgp